New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bn] enable Netlify preview for the dev-1.24-bn.1 #46226
Comments
Hi @kubernetes/sig-docs-leads |
/area localization |
/language bn |
/remove-kind support [This is not an end user asking for help.] /sig contributor-experience /triage accepted |
Is there something the team needs to do? |
Yes, there is a need from the Bengali team. The primary purpose is to support the review of Bengali-related PRs targeting the dev branch and to ensure the approval of error-free PRs. :) |
My question was that if there are some specific actions the sig-docs lead team need to take? |
@tengqm Oh, I misunderstood your comment. :) Some of the SIG-Docs leads have the authority to configure Netlify for a new branch. So, this request is for one of the leads to configure Netlify for the dev branch. |
There doesn't seem to me like a config option on Netlify for explicitly adding a branch into build. I did tried look around for such settings, but obviously I failed. Did we do this for the Korean translation? I mean, for each localization branch folks create, we have to adjust the Netlify settings? |
IIRC we can do this for any localization that wants it (usually, it's useful before the localization launches). I think we need to define a new site in Netlify for each localization we want to build. |
IIRC, yes I think we need to define a new site in Netlify for each localization. In case of Korean localization, we have
And recently, Arabic team got their page. :) |
Yes, this is a reasonable request. One of the things, IMO, localisation leads should be able to do is to help get this sorted for different localisations. We can, of course, discuss this in the streamlining discussion item further. Thoughts @reylejano @natalisucks |
Sorry I didn't get the point. Is the creation of a new netlify site mandatory? I don't think there is a k8s-dev-ja.netlify.app site, for example. But there are Even for the Korean localization, take this PR as an example, the "netlify preview" link works and it leads us to https://deploy-preview-46259--kubernetes-io-main-staging.netlify.app/. Where I am supposed to switch to the Korean localization, which is https://deploy-preview-46259--kubernetes-io-main-staging.netlify.app/ko/. I don't understand why we need a new config for a localization. My understanding is that all localization are built together when a PR is committed, thanks to the multi-lingual support by Hugo. I could be wrong though. |
Update: from #46264 we can see that the netlify preview works for the |
I believe localization subproject leads should have the ability to fulfill the request to create a Netlify site for preview for different localizations I didn't see a Netlify site for Bengali so I created one named kubernetes-io-bn-staging which deploys the dev-1.24-bn.1 branch This issue can be closed when the preview is confirmed to be working |
(I guess we've configured both /close |
@seokho-son: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The Bengali team is developing their localization in the https://github.com/kubernetes/website/tree/dev-1.24-bn.1 branch.
To ensure that the Bengali localization PRs are checked with a build test, Netlify needs to be enabled.
The text was updated successfully, but these errors were encountered: