Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bn] enable Netlify preview for the dev-1.24-bn.1 #46226

Closed
seokho-son opened this issue May 6, 2024 · 17 comments
Closed

[Bn] enable Netlify preview for the dev-1.24-bn.1 #46226

seokho-son opened this issue May 6, 2024 · 17 comments
Labels
area/localization General issues or PRs related to localization language/bn Issues or PRs related to Bengali language needs-kind Indicates a PR lacks a `kind/foo` label and requires one. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@seokho-son
Copy link
Member

The Bengali team is developing their localization in the https://github.com/kubernetes/website/tree/dev-1.24-bn.1 branch.

To ensure that the Bengali localization PRs are checked with a build test, Netlify needs to be enabled.

@seokho-son seokho-son added the kind/support Categorizes issue or PR as a support question. label May 6, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 6, 2024
@seokho-son
Copy link
Member Author

Hi @kubernetes/sig-docs-leads
This is request acceptable? :)

@seokho-son
Copy link
Member Author

/area localization

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label May 6, 2024
@seokho-son
Copy link
Member Author

/language bn

@k8s-ci-robot k8s-ci-robot added the language/bn Issues or PRs related to Bengali language label May 6, 2024
@sftim
Copy link
Contributor

sftim commented May 6, 2024

/remove-kind support

[This is not an end user asking for help.]

/sig contributor-experience

/triage accepted
Emeritus (!) tech lead here; I think the request is reasonable.

@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. triage/accepted Indicates an issue or PR is ready to be actively worked on. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. and removed kind/support Categorizes issue or PR as a support question. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 6, 2024
@tengqm
Copy link
Contributor

tengqm commented May 6, 2024

Is there something the team needs to do?

@seokho-son
Copy link
Member Author

Is there something the team needs to do?

Yes, there is a need from the Bengali team. The primary purpose is to support the review of Bengali-related PRs targeting the dev branch and to ensure the approval of error-free PRs. :)

@tengqm
Copy link
Contributor

tengqm commented May 7, 2024

My question was that if there are some specific actions the sig-docs lead team need to take?

@seokho-son
Copy link
Member Author

My question was that if there are some specific actions the sig-docs lead team need to take?

@tengqm Oh, I misunderstood your comment. :)

Some of the SIG-Docs leads have the authority to configure Netlify for a new branch. So, this request is for one of the leads to configure Netlify for the dev branch.
Currently, I am not sure who among the lead team has the authority, except for @reylejano.

@tengqm
Copy link
Contributor

tengqm commented May 7, 2024

There doesn't seem to me like a config option on Netlify for explicitly adding a branch into build. I did tried look around for such settings, but obviously I failed.

Did we do this for the Korean translation? I mean, for each localization branch folks create, we have to adjust the Netlify settings?

@sftim
Copy link
Contributor

sftim commented May 7, 2024

IIRC we can do this for any localization that wants it (usually, it's useful before the localization launches). I think we need to define a new site in Netlify for each localization we want to build.

@seokho-son
Copy link
Member Author

IIRC, yes I think we need to define a new site in Netlify for each localization.

In case of Korean localization, we have

And recently, Arabic team got their page. :)

@divya-mohan0209
Copy link
Contributor

Yes, this is a reasonable request. One of the things, IMO, localisation leads should be able to do is to help get this sorted for different localisations. We can, of course, discuss this in the streamlining discussion item further.

Thoughts @reylejano @natalisucks

@tengqm
Copy link
Contributor

tengqm commented May 7, 2024

Sorry I didn't get the point. Is the creation of a new netlify site mandatory? I don't think there is a k8s-dev-ja.netlify.app site, for example. But there are dev-<ver>-ja.<n> branches for the Japanese localization team to use.

Even for the Korean localization, take this PR as an example, the "netlify preview" link works and it leads us to https://deploy-preview-46259--kubernetes-io-main-staging.netlify.app/. Where I am supposed to switch to the Korean localization, which is https://deploy-preview-46259--kubernetes-io-main-staging.netlify.app/ko/. I don't understand why we need a new config for a localization. My understanding is that all localization are built together when a PR is committed, thanks to the multi-lingual support by Hugo. I could be wrong though.

@tengqm
Copy link
Contributor

tengqm commented May 8, 2024

Update: from #46264 we can see that the netlify preview works for the bn localization team. Although I'm not aware of any build time configuration changes, this issue can be closed, I think?

@reylejano
Copy link
Member

Yes, this is a reasonable request. One of the things, IMO, localisation leads should be able to do is to help get this sorted for different localisations. We can, of course, discuss this in the streamlining discussion item further.

Thoughts @reylejano @natalisucks

I believe localization subproject leads should have the ability to fulfill the request to create a Netlify site for preview for different localizations

I didn't see a Netlify site for Bengali so I created one named kubernetes-io-bn-staging which deploys the dev-1.24-bn.1 branch

This issue can be closed when the preview is confirmed to be working

@seokho-son
Copy link
Member Author

seokho-son commented May 14, 2024

(I guess we've configured both main-staging and bn-staging sites for kubernetes:dev-1.24-bn.1. So, PRs to dev-1.24-bn.1 will show preview for both. ex: #46313)

/close

@k8s-ci-robot
Copy link
Contributor

@seokho-son: Closing this issue.

In response to this:

(I guess we've configured both main-staging and ben-staging sites for kubernetes:dev-1.24-bn.1. So, PRs to dev-1.24-bn.1 will show preview for both.)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization language/bn Issues or PRs related to Bengali language needs-kind Indicates a PR lacks a `kind/foo` label and requires one. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

6 participants