Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable click-to-zoom for some diagrams and other images #38051

Closed
Ritikaa96 opened this issue Nov 24, 2022 · 14 comments · Fixed by #46260
Closed

Enable click-to-zoom for some diagrams and other images #38051

Ritikaa96 opened this issue Nov 24, 2022 · 14 comments · Fixed by #46260
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@Ritikaa96
Copy link
Contributor

This is a Feature Request

Some images in concepts sections are quite detailed but in normal scope the texts inside of them look small and unreadable.
Can we add feature for the images to pop up on clicking?
It will add to the user experience as well as ease the pain of zooming out the page in whole.

What would you like to be added
Feature to Pop up images on click

Why is this needed
The texts and details seem too small to read.

Comments
Reference of some of the pages where the issue arises:

Example to the pop-up view for image:
https://keda.sh/docs/2.7/concepts/#architecture

@Ritikaa96 Ritikaa96 added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 24, 2022
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 24, 2022
@Ritikaa96
Copy link
Contributor Author

/area web-development
/kind feature

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Nov 24, 2022
@sftim
Copy link
Contributor

sftim commented Nov 24, 2022

/area web-development

Something similar to https://medium-zoom.francoischalifour.com/ ?

@sftim
Copy link
Contributor

sftim commented Nov 24, 2022

/retitle Enable click-to-zoom for some diagrams and other images

@k8s-ci-robot k8s-ci-robot changed the title Add pop up to the images in website Enable click-to-zoom for some diagrams and other images Nov 24, 2022
@sftim
Copy link
Contributor

sftim commented Nov 24, 2022

/triage accepted
/priority backlog
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 24, 2022
@Ritikaa96
Copy link
Contributor Author

Thanks @sftim ,
I investigated on hugo's documents regarding any shortcode or feature that provide this functionality. but till now haven't found any.

@Ritikaa96
Copy link
Contributor Author

For now I'll investigate more and try to find out what can work so assigning it to myself
/assign

@sftim
Copy link
Contributor

sftim commented Nov 24, 2022

A couple of hints:

{{- if .HasShortcode "figure" -}}

<!-- Enable zoom-on-click for figures that opt in to this -->
<script defer src="{{ "/js/zoom.js" | relURL }}"></script>
{{- end -}}
{{<figure src="/images/blog/2019-03-21-a-guide-to-kubernetes-admission-controllers/admission-controller-phases.png" clicktozoom="true" >}}

@Ritikaa96
Copy link
Contributor Author

There is one more way like the above reference link mentioned,
If we put full-resolution images in other paths and do this :
[![Alternative Text](/path/of/image.jpg)](/path/to/image.jpg)

It is in case we want minimal change in the code.
I'm going to add ways here as I find so the community can vote or suggest which will be better for a clean code

@Ritikaa96
Copy link
Contributor Author

This
one is a good reference for same functionality with example.
I'll try both and raise a PR after that.

@sftim
Copy link
Contributor

sftim commented Nov 25, 2022

full-resolution images

We recommend using vector images.

@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jan 19, 2024
@Ritikaa96 Ritikaa96 removed their assignment Jan 25, 2024
@Ritikaa96
Copy link
Contributor Author

My apologies,Due to bandwidth issue couldn't work on this, It's open for other people to self-assign.

@dipesh-rawat
Copy link
Member

This could be a positive and beneficial addition to the website.
Worth doing (re-triaging as accepted).

/triage accepted
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 7, 2024
@dipesh-rawat
Copy link
Member

dipesh-rawat commented May 7, 2024

Let me see if I can assist with this.

Edit: I request review and feedback on pull request #46260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants