New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify remark about object names wrt CRD #46263
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -161,7 +161,7 @@ The [CustomResourceDefinition](/docs/tasks/extend-kubernetes/custom-resources/cu | |||
API resource allows you to define custom resources. | |||
Defining a CRD object creates a new custom resource with a name and schema that you specify. | |||
The Kubernetes API serves and handles the storage of your custom resource. | |||
The name of a CRD object must be a valid | |||
The name of an object whose kind/resource is defined by a CRD must be a valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds to me that this paragraph focuses more on the CRD rather than the CRs created from the CRDs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I recommend:
- revert this line
- add some more text at the end of the paragraph that talks about restrictions on names of CRs, with a bit of a more verbose explanation about the difference between a CRD and the CRs you can create once a CRD is defined.
This PR clarifies the remark about the restrictions on the name of an object whose kind/resource is defined by a CRD.
Fixes #46262