Addition of Test Case for Non-Existent Framework in GetFrameworkCmd #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… GetFrameworkCmd) Description: This pull request introduces a new test case TestGetFrameworkCmdWithNonExistentFramework in the framework_test.go file. The purpose of this test case is to verify the behavior of the getFrameworkCmd function when it's run with a non-existent framework argument. In this test case, we: Create a mock Kubescape interface and a ScanInfo object Call the getFrameworkCmd function with the mock interface and ScanInfo object Run the command with a non-existent framework argument Check that there is an error and the error message is "bad argument: account ID must be a valid UUID" This test case enhances the test coverage of the getFrameworkCmd function and ensures that it correctly handles non-existent framework arguments. Signed-off-by: Umair <58398786+Umair0343@users.noreply.github.com>
matthyx
approved these changes
Nov 26, 2023
VaibhavMalik4187
added a commit
to VaibhavMalik4187/kubescape
that referenced
this pull request
Nov 30, 2023
Updated the `getSortPackageScores` function to fix the crash in the scan command. Fixes: kubescape#1533 Signed-off-by: VaibhavMalik4187 <vaibhavmalik2018@gmail.com>
|
/describe |
github-actions
bot
changed the title
|
PR Description updated to latest commit (5172ce3) |
|
/describe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Tests
Description
This pull request introduces a new test case
TestGetFrameworkCmdWithNonExistentFrameworkin theframework_test.gofile. The main changes include:getFrameworkCmdfunction with the mock interface and ScanInfo object.This enhancement increases the test coverage of the
getFrameworkCmdfunction and ensures that it correctly handles non-existent framework arguments.PR changes walkthrough
1 files
framework_test.go
cmd/scan/framework_test.go
A new test case
`TestGetFrameworkCmdWithNonExistentFramework` has been added
to test the behavior of the `getFrameworkCmd` function when
it's run with a non-existent framework argument.