Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: fix: modify regex to check tag with only chars #402

Closed
wants to merge 1 commit into from
Closed

WIP: fix: modify regex to check tag with only chars #402

wants to merge 1 commit into from

Conversation

alegrey91
Copy link
Contributor

Overview

The previous regex seemed not working properly. We are now able to check image tags composed only by characters.

Related issues/PRs:

Fix #351

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas
  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • New and existing unit tests pass locally with my changes

@alegrey91
fix: modify regex to check tag with only chars
451c2aa 
Signed-off-by: Alessio Greggi <ale_grey_91@hotmail.it>
@alegrey91 alegrey91 marked this pull request as draft May 23, 2023 13:48
@alegrey91 alegrey91 changed the title fix: modify regex to check tag with only chars WIP: fix: modify regex to check tag with only chars May 23, 2023
@github-actions
Copy link
Contributor

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@alegrey91 alegrey91 closed this May 30, 2023
@dwertent dwertent deleted the fix/control-0075-image-pull-policy-on-latest-tag branch August 2, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YiscahLevySilas1 YiscahLevySilas1 Awaiting requested review from YiscahLevySilas1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Control 0075 - Image pull policy on latest tag triggers randomly
1 participant
@alegrey91