Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration param to C-0050 to optionally check cpu limit #391

Open
sboschman opened this issue May 15, 2023 · 1 comment
Open

Add configuration param to C-0050 to optionally check cpu limit #391

sboschman opened this issue May 15, 2023 · 1 comment

Comments

@sboschman
Copy link

Overview

Currently C-0050 checks if both cpu requests and cpu limits are set. Optionally a min/max value for both values can be configured.

Problem

Setting a cpu limit can have unwanted side effects, a good article on this topic is f.e. https://home.robusta.dev/blog/stop-using-cpu-limits. Enforcing the cpu requests, on the other hand, is a good idea.
The controls for checking resource requests and limits are C-0004, C-0009 and C-0050. But we cannot make a combination to check only memory requests, memory limits and cpu requests.
Adding an exception does not work as it can not differentiate between just missing the cpu limit or missing the cpu requests as well.

Solution

Add an additional configuration param to C-0050 to opt-out of the cpu limit check, so only cpu requests is checked.

Alternatives

Additional context

@matheensyedaslam
Copy link

Would love to see this feature added as we are looking into same option for scans !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants