Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listOfDangerousArtifacts defined but not used #510

Open
craigbox opened this issue Oct 2, 2023 · 3 comments
Open

listOfDangerousArtifacts defined but not used #510

craigbox opened this issue Oct 2, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@craigbox
Copy link
Contributor

craigbox commented Oct 2, 2023

default-config-inputs.json contains a section:

            "listOfDangerousArtifacts": [
                "bin/bash",
                "sbin/sh",
                "bin/ksh",
                "bin/tcsh",
                "bin/zsh",
                "usr/bin/scsh",
                "bin/csh",
                "bin/busybox",
                "usr/bin/busybox"
            ],

No rule appears to use these, as surmised by a search for listOfDangerousArtifacts only finding this file.

@craigbox craigbox added the bug Something isn't working label Oct 2, 2023
@VaibhavMalik4187
Copy link

@craigbox mind if I ask what makes this a bug? Also, since this list is not being used, would it be right to get rid of it?

Going through the logs I found that commit: 1daf7d2 got rid of the last rule that was using this list.

@craigbox
Copy link
Contributor Author

mind if I ask what makes this a bug?

The fact I was writing documentation for the list of configurable items!

@craigbox
Copy link
Contributor Author

(/cc @amirmalka who committed that change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants