Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset name in sha256sums.txt is wrong #4822

Closed
suzuki-shunsuke opened this issue Oct 4, 2022 · 3 comments · Fixed by #4830
Closed

Asset name in sha256sums.txt is wrong #4822

suzuki-shunsuke opened this issue Oct 4, 2022 · 3 comments · Fixed by #4830
Labels
type/bug Something isn't working type/docs Improvements or additions to documentation
Milestone

Comments

@suzuki-shunsuke
Copy link

Describe the bug

https://github.com/kubevela/kubevela/releases/download/v1.5.6/sha256sums.txt includes checksums and file names,
but file names are different from GitHub Releases asset names.

https://github.com/kubevela/kubevela/releases/tag/v1.5.6

c7834a1cb5f996788b136080ab19ff48ab4721ab4dd361a33f7a89e74ecc2c3e  vela/vela-darwin-amd64.tar.gz
99487c12e019d425774a041a22f4dd8ab5dac4b8500d8206d3f85b04381d45ab  vela/vela-darwin-amd64.zip
4cb911ac81346f44957bd8e4f9649b5f473dd38a070e7a384a361f7ac677d4d6  kubectl-vela/kubectl-vela-darwin-amd64.tar.gz
73dfa22948772b6e78c1792e0aedfed8115a40df6980fa429f4b854da38e2866  kubectl-vela/kubectl-vela-darwin-amd64.zip
2246a7b7353688232a16dd75659e0aaf9a77a8913bb90144b5caea502d3753a2  vela/vela-darwin-arm64.tar.gz
bc2ee7c273a0e01a00970c7a4747b10e061e93338bd54c40eb2b8523923d642d  vela/vela-darwin-arm64.zip
829c60943e2f2e1116f4c621f4ae6f1a6aba7970a9a712ad180aa2853be0b4c3  kubectl-vela/kubectl-vela-darwin-arm64.tar.gz
097ed767254e3220ddb58885111a83a45534912786eb7750461d083675e8e907  kubectl-vela/kubectl-vela-darwin-arm64.zip
f4a6890311f9b3ee1e275c44b6cea0901102cf7fe7472e80e658c95a2f5ecc14  vela/vela-linux-amd64.tar.gz
b4d4d82c178c2aafd335441d9210da11460f6815581d9aec6adbf755a2aa60b3  vela/vela-linux-amd64.zip
6a607e385d0a7e326575a86b26d476a5197ad905f0ba17363f81b428d9fcaff6  kubectl-vela/kubectl-vela-linux-amd64.tar.gz
5da271ebfed8d05b39b699b555862966a0a625b8f2d3157f3b0989060c50eeb8  kubectl-vela/kubectl-vela-linux-amd64.zip
df80e53e66eb83e1e9286a668cb6e633632f01fd7197ea79908e778abc89cebd  vela/vela-linux-arm64.tar.gz
d62d7b29dc376d7aa95e60903320e5f69e22229fbe5c58c5cc84a78f1f057dee  vela/vela-linux-arm64.zip
865df1c91b9a020c5db19406b837818c3686d1239440665e5c2547088272e016  kubectl-vela/kubectl-vela-linux-arm64.tar.gz
266b99162e97d474e8980f8a91f49a67a5f25926c7b3983dbafe7018a207eaf1  kubectl-vela/kubectl-vela-linux-arm64.zip
84f46251828ad6a113e77622af47ab1ec4fe8bfa61236d31a41aa7fa476726c5  vela/vela-windows-amd64.tar.gz
5987e82ad556d00a20bad13b5b5f22b7d68685e935c6860df49b80bcf09d33a9  vela/vela-windows-amd64.zip
d425b14c3d7f28d7e42f4b669d947bf72799ba144494dc4983a3ba23ab5abcc8  kubectl-vela/kubectl-vela-windows-amd64.tar.gz
9f392cc740334074295dcebbc0d53fc5942c38abf26cdd3d27006cf2c608ddcf  kubectl-vela/kubectl-vela-windows-amd64.zip

Assets in GitHub Releases have the version v1.5.6 (e.g. kubectl-vela-v1.5.6-darwin-amd64.tar.gz), but file names in sha256sums.txt don't have the version.

To Reproduce

Expected behavior

The file names in sha256sums.txt should be same as asset names.

Actual

c7834a1cb5f996788b136080ab19ff48ab4721ab4dd361a33f7a89e74ecc2c3e  vela/vela-darwin-amd64.tar.gz

Expected

c7834a1cb5f996788b136080ab19ff48ab4721ab4dd361a33f7a89e74ecc2c3e  vela-v1.5.6-darwin-amd64.tar.gz

Screenshots

image

KubeVela Version

Cluster information

Additional context

@oeular oeular added type/docs Improvements or additions to documentation needs more info the issue is not clear and more information need to be added labels Oct 5, 2022
suzuki-shunsuke added a commit to aquaproj/aqua-registry that referenced this issue Oct 5, 2022
@wonderflow wonderflow added type/bug Something isn't working and removed needs more info the issue is not clear and more information need to be added labels Oct 7, 2022
@wonderflow
Copy link
Collaborator

Thanks for reporting @suzuki-shunsuke , it must be a bug about generating the checksum file, we'll fix it ASAP.

@wonderflow
Copy link
Collaborator

@suzuki-shunsuke Hi, it's fixed in the new release https://github.com/kubevela/kubevela/releases/tag/v1.5.7

@suzuki-shunsuke
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants