-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
velaux 1.9.1 Configure the gateway, and convert the port into a string #6165
Comments
Could you provide a screenshot? |
@Louse-luo : please provide an example manifest which fails, thanks. |
thanks @wonderflow do we know the last version where this didn't happen? and can you publish a full repro for getting to this state shown in the screenshot? |
@Kolossi Thanks Paul for investigating this issue. The reporter didn't send the full repro, so I can't provide that. I checked the gateway trait: It's defined as |
Indeed, I looked and saw the same. Also, my changes to gateway were included in v1.9.0 and doing a diff to previous 1.8.2, there's nothing changed around port - v1.8.2...v1.9.1#diff-eb6e43f0e2cf800a96e1dac66f3f4871067f865d5c694d9efa5c84cb2529a5a0 Is there something hardcoded in velaux about ports which has broken (again I tried a github search and couldn't find anything). 🤔 |
ping @chivalryq @barnettZQG , will it possible that's a bug caused by velaux? |
I will dig into this recently. |
same problem in 1.9.1; now we degrade to 1.8.1 ; keep an eye on this |
@lxkaka : can you post the steps to reproduce this issue please |
Let's check the open API schema that generate from the gateway trait, it save in a configmap. @chivalryq |
@Kolossi |
@chivalryq I really can't see anything in either kubevela or velaux diff between 1.8.1 and 1.9.1. Perhaps it's a change in the underlying cue version that has changed the behaviour? I'm going to have to leave this with you. |
@Kolossi No worry. Will take care of this. |
OpenAPI schema is like below. It's like there's something wrong in grammar. Still investigating. {
"properties": {
"class": {
"default": "nginx",
"description": "Specify the class of ingress to use",
"title": "class",
"type": "string"
},
"classInSpec": {
"default": false,
"description": "Set ingress class in ''.spec.ingressClassName'' instead of ''kubernetes.io/ingress.class'' annotation.",
"title": "classInSpec",
"type": "boolean"
},
"domain": {
"description": "Specify the domain you want to expose",
"title": "domain",
"type": "string"
},
"gatewayHost": {
"description": "Specify the host of the ingress gateway, which is used to generate the endpoints when the host is empty.",
"title": "gatewayHost",
"type": "string"
},
"http": {
"additionalProperties": {
"type": "integer"
},
"description": "Specify the mapping relationship between the http path and the workload port",
"title": "http",
"type": "object"
},
"secretName": {
"description": "Specify the secret name you want to quote to use tls.",
"title": "secretName",
"type": "string"
}
},
"required": [
"http",
"class",
"classInSpec" [],
"type"
:
"object"
} |
@chivalryq we will keep an eye on this |
Openapi schema is not wrong. It's a k9s bug. |
Describe the bug
velaux 1.9.1 Configure the gateway, and convert the port into a string
To Reproduce
cannot generate manifests from components and traits: evaluate template trait=gateway app=third-app1-prod: invalid template of trait gateway after merge with parameter and context: outputs.service.spec.ports.0.port: conflicting values "8090" and int (mismatched types string and int) (and 3 more errors)
Expected behavior
Screenshots
KubeVela Version
1.9.1
Cluster information
Additional context
The text was updated successfully, but these errors were encountered: