Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: replace deprecated command with environment file #385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Chore: replace deprecated command with environment file #385

wants to merge 1 commit into from

Conversation

jongwooo
Copy link

Description

Closes #384

Update .github/workflows/release.yml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow file that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

- name: Get matrix
  id: get_matrix
  run: |
    TARGETS=${{matrix.TARGETS}}
    echo ::set-output name=OS::${TARGETS%/*}
    echo ::set-output name=ARCH::${TARGETS#*/}

TO-BE

- name: Get matrix
  id: get_matri
  shell: bash
  run: |
    TARGETS=${{matrix.TARGETS}}
    echo "OS=${TARGETS%/*}" >> $GITHUB_OUTPUT
    echo "ARCH=${TARGETS#*/}" >> $GITHUB_OUTPUT

@jongwooo
Chore: replace deprecated command with environment file
324f3e3 
Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3a96f68) 79.31% compared to head (324f3e3) 0.00%.
Report is 21 commits behind head on master.

Files Patch % Lines
e2e/normal/regression.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #385       +/-   ##
==========================================
- Coverage   79.31%   0.00%   -79.32%     
==========================================
  Files          23       1       -22     
  Lines        1750      71     -1679     
==========================================
- Hits         1388       0     -1388     
+ Misses        278      71      -207     
+ Partials       84       0       -84
Flag Coverage Δ
e2e 0.00% <0.00%> (∅)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
1 participant
@jongwooo