-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create kubevirt-node-validate #11890
Comments
Would this be a CLI tool? Or an addition to virtctl?
How would you envision it to work?
i.e.
```console
$ virtctl adm node-validate
foo01 PASS
foo02 PASS
bar42 FAIL - Missing …
$
```
Or how?
|
We would need to run it on the node, similar to Not sure how many checks we would need, but it feels right to have a place we could add KubeVirt specific node requirements.
At first, just a CLI tool. Could perhaps be integrated with |
I'm a bit uncertain if we should really run "virt-host-validate" as part of kubevirt. Ideally, we should expose the various virtualization features in a way that kubernetes can understand and that they can be query also by regular users and ideally used by the scheduler. |
Can we return 1024 if |
Is your feature request related to a problem? Please describe:
Sometimes it is hard to tell if KubeVirt can run in a given node or not. For instance, it is common to ask user to run
virt-host-validate
to check if something is missing on virtualization side but part of our stack might require new enough kernel or with some capabilities enabled.Describe the solution you'd like:
We should have a tool that we could put this runtime requirements.
Additional context:
At the minimum, if a component crashes due lack of system's feature, we should be able to track it down by running this tool.
Perhaps it can be used to avoid scheduling VMs in unsupported nodes (I'm sure we already have code that does this kind of checks)
See: #11886
The text was updated successfully, but these errors were encountered: