Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Luxon #132

Open
wakonp opened this issue Apr 11, 2021 · 2 comments
Open

Support for Luxon #132

wakonp opened this issue Apr 11, 2021 · 2 comments

Comments

@wakonp
Copy link

wakonp commented Apr 11, 2021

Hey guys, I really appreciate your work and would like to contribute to your project with this little script.

https://gist.github.com/wakonp/e714ccd3384c16becf124e06216be0f3

Maybe you can add the support for Luxon. The DateTimeAdapter uses the same Options provided in this library https://github.com/andreialecu/ngx-material-luxon

@bbortt
Copy link
Collaborator

bbortt commented Apr 14, 2021

this looks interesting indeed! i will take a look at it..

@bbortt
Copy link
Collaborator

bbortt commented Dec 30, 2021

hi @wakonp, I finally found time to look at your adapter. I've never heard of luxon, but looked it up and it sounds great.
the code looks fine to me in general, why don't you want to submit a PR yourself? from what I see..

  • this requires a second subproject (you can roughly copy @mat-datetimepicker/moment),
  • the formats are missing,
  • an example must be added (src/app/luxon, copy from src/app/moment as well)
  • and an additional section in README.md.
  • you'd also have to include the new module in some scripts for publishing (package.json, .github/workflows).

I can help you out if you have any questions, of course. but for now I myself will rather be focused on the ~40 remaining but reports..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants