Skip to content

Commit ca8d7c4

Browse files
ahnpnlahnpnl
authoredDec 7, 2020
feat: allow subclasses of TsJestTransformer to have version checking (#2176)
·
v29.3.0v27.0.0-next.2
1 parent 0b0d93d commit ca8d7c4

File tree

23 files changed

+77
-65
lines changed

23 files changed

+77
-65
lines changed
 

‎e2e/__external-repos__/custom-typings/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"test": "jest"
66
},
77
"devDependencies": {
8-
"@types/jest": "^26.0.15",
8+
"@types/jest": "^26.0.16",
99
"@types/jquery": "^3.5.4",
1010
"jest": "^26.6.3",
1111
"jquery": "^3.5.1",

‎e2e/__external-repos__/custom-typings/yarn.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -578,10 +578,10 @@
578578
dependencies:
579579
"@types/istanbul-lib-report" "*"
580580

581-
"@types/jest@^26.0.15":
582-
version "26.0.15"
583-
resolved "https://registry.yarnpkg.com/@types/jest/-/jest-26.0.15.tgz#12e02c0372ad0548e07b9f4e19132b834cb1effe"
584-
integrity sha512-s2VMReFXRg9XXxV+CW9e5Nz8fH2K1aEhwgjUqPPbQd7g95T0laAcvLv032EhFHIa5GHsZ8W7iJEQVaJq6k3Gog==
581+
"@types/jest@^26.0.16":
582+
version "26.0.16"
583+
resolved "https://registry.yarnpkg.com/@types/jest/-/jest-26.0.16.tgz#b47abd50f6ed0503f589db8e126fc8eb470cf87c"
584+
integrity sha512-Gp12+7tmKCgv9JjtltxUXokohCAEZfpJaEW5tn871SGRp8I+bRWBonQO7vW5NHwnAHe5dd50+Q4zyKuN35i09g==
585585
dependencies:
586586
jest-diff "^26.0.0"
587587
pretty-format "^26.0.0"

‎e2e/__external-repos__/memory-usage/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"@nestjs/core": "^7.5.5",
2929
"@nestjs/platform-express": "^7.5.5",
3030
"@nestjs/testing": "^7.5.5",
31-
"@types/jest": "^26.0.15",
31+
"@types/jest": "^26.0.16",
3232
"@types/lodash": "^4.14.165",
3333
"jest": "^26.6.3",
3434
"lodash": "^4.17.20",

‎e2e/__external-repos__/memory-usage/yarn.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -601,10 +601,10 @@
601601
dependencies:
602602
"@types/istanbul-lib-report" "*"
603603

604-
"@types/jest@^26.0.15":
605-
version "26.0.15"
606-
resolved "https://registry.yarnpkg.com/@types/jest/-/jest-26.0.15.tgz#12e02c0372ad0548e07b9f4e19132b834cb1effe"
607-
integrity sha512-s2VMReFXRg9XXxV+CW9e5Nz8fH2K1aEhwgjUqPPbQd7g95T0laAcvLv032EhFHIa5GHsZ8W7iJEQVaJq6k3Gog==
604+
"@types/jest@^26.0.16":
605+
version "26.0.16"
606+
resolved "https://registry.yarnpkg.com/@types/jest/-/jest-26.0.16.tgz#b47abd50f6ed0503f589db8e126fc8eb470cf87c"
607+
integrity sha512-Gp12+7tmKCgv9JjtltxUXokohCAEZfpJaEW5tn871SGRp8I+bRWBonQO7vW5NHwnAHe5dd50+Q4zyKuN35i09g==
608608
dependencies:
609609
jest-diff "^26.0.0"
610610
pretty-format "^26.0.0"

‎e2e/__external-repos__/path-mapping/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "ts-jest-example",
33
"private": true,
44
"devDependencies": {
5-
"@types/jest": "^26.0.15",
5+
"@types/jest": "^26.0.16",
66
"jest": "^26.6.3",
77
"typescript": "^4.1.2"
88
},

‎e2e/__external-repos__/path-mapping/yarn.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -561,10 +561,10 @@
561561
dependencies:
562562
"@types/istanbul-lib-report" "*"
563563

564-
"@types/jest@^26.0.15":
565-
version "26.0.15"
566-
resolved "https://registry.yarnpkg.com/@types/jest/-/jest-26.0.15.tgz#12e02c0372ad0548e07b9f4e19132b834cb1effe"
567-
integrity sha512-s2VMReFXRg9XXxV+CW9e5Nz8fH2K1aEhwgjUqPPbQd7g95T0laAcvLv032EhFHIa5GHsZ8W7iJEQVaJq6k3Gog==
564+
"@types/jest@^26.0.16":
565+
version "26.0.16"
566+
resolved "https://registry.yarnpkg.com/@types/jest/-/jest-26.0.16.tgz#b47abd50f6ed0503f589db8e126fc8eb470cf87c"
567+
integrity sha512-Gp12+7tmKCgv9JjtltxUXokohCAEZfpJaEW5tn871SGRp8I+bRWBonQO7vW5NHwnAHe5dd50+Q4zyKuN35i09g==
568568
dependencies:
569569
jest-diff "^26.0.0"
570570
pretty-format "^26.0.0"

‎e2e/__external-repos__/simple-project-references/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"test": "jest"
66
},
77
"devDependencies": {
8-
"@types/jest": "^26.0.15",
8+
"@types/jest": "^26.0.16",
99
"@types/lodash": "^4.14.165",
1010
"jest": "^26.6.3",
1111
"typescript": "^4.1.2"

‎e2e/__external-repos__/simple-project-references/yarn.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -578,10 +578,10 @@
578578
dependencies:
579579
"@types/istanbul-lib-report" "*"
580580

581-
"@types/jest@^26.0.15":
582-
version "26.0.15"
583-
resolved "https://registry.yarnpkg.com/@types/jest/-/jest-26.0.15.tgz#12e02c0372ad0548e07b9f4e19132b834cb1effe"
584-
integrity sha512-s2VMReFXRg9XXxV+CW9e5Nz8fH2K1aEhwgjUqPPbQd7g95T0laAcvLv032EhFHIa5GHsZ8W7iJEQVaJq6k3Gog==
581+
"@types/jest@^26.0.16":
582+
version "26.0.16"
583+
resolved "https://registry.yarnpkg.com/@types/jest/-/jest-26.0.16.tgz#b47abd50f6ed0503f589db8e126fc8eb470cf87c"
584+
integrity sha512-Gp12+7tmKCgv9JjtltxUXokohCAEZfpJaEW5tn871SGRp8I+bRWBonQO7vW5NHwnAHe5dd50+Q4zyKuN35i09g==
585585
dependencies:
586586
jest-diff "^26.0.0"
587587
pretty-format "^26.0.0"

‎e2e/__external-repos__/simple/with-dependency/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
}
3737
},
3838
"devDependencies": {
39-
"@types/jest": "^26.0.15",
39+
"@types/jest": "^26.0.16",
4040
"dependency": "file:../dependency",
4141
"jest": "^26.6.3",
4242
"typescript": "^4.1.2"

‎e2e/__external-repos__/simple/with-dependency/yarn.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -578,10 +578,10 @@
578578
dependencies:
579579
"@types/istanbul-lib-report" "*"
580580

581-
"@types/jest@^26.0.15":
582-
version "26.0.15"
583-
resolved "https://registry.yarnpkg.com/@types/jest/-/jest-26.0.15.tgz#12e02c0372ad0548e07b9f4e19132b834cb1effe"
584-
integrity sha512-s2VMReFXRg9XXxV+CW9e5Nz8fH2K1aEhwgjUqPPbQd7g95T0laAcvLv032EhFHIa5GHsZ8W7iJEQVaJq6k3Gog==
581+
"@types/jest@^26.0.16":
582+
version "26.0.16"
583+
resolved "https://registry.yarnpkg.com/@types/jest/-/jest-26.0.16.tgz#b47abd50f6ed0503f589db8e126fc8eb470cf87c"
584+
integrity sha512-Gp12+7tmKCgv9JjtltxUXokohCAEZfpJaEW5tn871SGRp8I+bRWBonQO7vW5NHwnAHe5dd50+Q4zyKuN35i09g==
585585
dependencies:
586586
jest-diff "^26.0.0"
587587
pretty-format "^26.0.0"

‎e2e/__external-repos__/yarn-workspace-composite/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"test": "jest --no-cache"
99
},
1010
"devDependencies": {
11-
"@types/jest": "^26.0.15",
11+
"@types/jest": "^26.0.16",
1212
"jest": "^26.6.3",
1313
"typescript": "^4.1.2"
1414
},

‎e2e/__external-repos__/yarn-workspace-composite/yarn.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -578,10 +578,10 @@
578578
dependencies:
579579
"@types/istanbul-lib-report" "*"
580580

581-
"@types/jest@^26.0.15":
582-
version "26.0.15"
583-
resolved "https://registry.yarnpkg.com/@types/jest/-/jest-26.0.15.tgz#12e02c0372ad0548e07b9f4e19132b834cb1effe"
584-
integrity sha512-s2VMReFXRg9XXxV+CW9e5Nz8fH2K1aEhwgjUqPPbQd7g95T0laAcvLv032EhFHIa5GHsZ8W7iJEQVaJq6k3Gog==
581+
"@types/jest@^26.0.16":
582+
version "26.0.16"
583+
resolved "https://registry.yarnpkg.com/@types/jest/-/jest-26.0.16.tgz#b47abd50f6ed0503f589db8e126fc8eb470cf87c"
584+
integrity sha512-Gp12+7tmKCgv9JjtltxUXokohCAEZfpJaEW5tn871SGRp8I+bRWBonQO7vW5NHwnAHe5dd50+Q4zyKuN35i09g==
585585
dependencies:
586586
jest-diff "^26.0.0"
587587
pretty-format "^26.0.0"

‎e2e/__templates__/default/package-lock.json

+7-7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎e2e/__templates__/default/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"version": "0.0.0-tmpl.0",
44
"private": true,
55
"devDependencies": {
6-
"@types/jest": "26.0.15",
6+
"@types/jest": "26.0.16",
77
"@types/node": "12.19.0",
88
"jest": "26.6.3",
99
"typescript": "4.1.2"

‎e2e/__templates__/with-babel-7-string-config/package-lock.json

+7-7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎e2e/__templates__/with-babel-7-string-config/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"devDependencies": {
66
"@babel/core": "7.12.3",
77
"@babel/preset-env": "7.12.1",
8-
"@types/jest": "26.0.15",
8+
"@types/jest": "26.0.16",
99
"@types/node": "12.19.0",
1010
"babel-jest": "26.6.3",
1111
"jest": "26.6.3",

‎e2e/__templates__/with-babel-7/package-lock.json

+7-7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎e2e/__templates__/with-babel-7/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"devDependencies": {
66
"@babel/core": "7.12.3",
77
"@babel/preset-env": "7.12.1",
8-
"@types/jest": "26.0.15",
8+
"@types/jest": "26.0.16",
99
"@types/node": "12.19.0",
1010
"babel-jest": "26.6.3",
1111
"jest": "26.6.3",

‎e2e/__templates__/with-unsupported-version/package-lock.json

+7-7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎e2e/__templates__/with-unsupported-version/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"version": "0.0.0-tmpl.0",
44
"private": true,
55
"devDependencies": {
6-
"@types/jest": "26.0.15",
6+
"@types/jest": "26.0.16",
77
"@types/node": "12.19.0",
88
"jest": "26.6.3",
99
"typescript": "3.7.5"

‎src/index.ts

-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
1-
import { VersionCheckers } from './utils/version-checkers'
21
import { TsJestTransformer } from './ts-jest-transformer'
32

43
export function createTransformer(): TsJestTransformer {
5-
VersionCheckers.jest.warn()
6-
74
return new TsJestTransformer()
85
}

‎src/ts-jest-transformer.spec.ts

+13
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import { CACHE_KEY_EL_SEPARATOR, TsJestTransformer } from './ts-jest-transformer
1313
import type { ResolvedModulesMap } from './types'
1414
import { stringify } from './utils/json'
1515
import { sha1 } from './utils/sha1'
16+
import { VersionCheckers } from './utils/version-checkers'
1617

1718
const logTarget = logTargetMock()
1819
const cacheDir = join(process.cwd(), 'tmp')
@@ -360,4 +361,16 @@ describe('TsJestTransformer', () => {
360361
}
361362
})
362363
})
364+
365+
describe('subclass extends TsJestTransformer', () => {
366+
class MyTransformer extends TsJestTransformer {}
367+
368+
test('should have jest version checking', () => {
369+
VersionCheckers.jest.warn = jest.fn()
370+
371+
new MyTransformer()
372+
373+
expect(VersionCheckers.jest.warn).toHaveBeenCalled()
374+
})
375+
})
363376
})

‎src/ts-jest-transformer.ts

+2
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import { rootLogger } from './utils/logger'
1414
import { Errors, interpolate } from './utils/messages'
1515
import type { CompilerInstance } from './types'
1616
import { sha1 } from './utils/sha1'
17+
import { VersionCheckers } from './utils/version-checkers'
1718

1819
interface CachedConfigSet {
1920
configSet: ConfigSet
@@ -47,6 +48,7 @@ export class TsJestTransformer implements Transformer {
4748

4849
constructor() {
4950
this._logger = rootLogger.child({ namespace: 'ts-jest-transformer' })
51+
VersionCheckers.jest.warn()
5052

5153
this._logger.debug('created new transformer')
5254
}

0 commit comments

Comments
 (0)
Please sign in to comment.