Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): support babel config file path as string #1332

Merged
merged 5 commits into from Dec 31, 2019
Merged

fix(config): support babel config file path as string #1332

merged 5 commits into from Dec 31, 2019

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Dec 29, 2019

close #933 #1309

@coveralls
Copy link

coveralls commented Dec 29, 2019 •
edited

Pull Request Test Coverage Report for Build 3834

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 90.286%
Totals Coverage Status
Change from base Build 3830: 0.2%
Covered Lines: 1075
Relevant Lines: 1133
💛 - Coveralls

kulshekhar
kulshekhar previously approved these changes Dec 30, 2019
View reviewed changes
@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Dec 30, 2019 •
edited

hi @kulshekhar , please don't merge because i want to improve the coverage for the new added codes.

updated: looks good now, we are back to original coverage

@ahnpnl ahnpnl merged commit 78a53c2 into kulshekhar:master Dec 31, 2019
@ahnpnl ahnpnl deleted the fix/support-babel-config-js-string branch December 31, 2019 10:14
@ahnpnl ahnpnl mentioned this pull request Dec 31, 2019
Closed
@ntucker
Copy link

ntucker commented Jan 5, 2020

Release new version pls? :)

@kulshekhar
Copy link
Owner

@ntucker done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ts-jest does not support new Babel 7 Project-wide config file
4 participants
@ahnpnl @coveralls @ntucker @kulshekhar