New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: jest 25 type definitions #1363
fix: jest 25 type definitions #1363
Conversation
A lot of the Jest typings were moved into the core repo rather than the `@types/jest` definitions. See DefinitelyTyped/DefinitelyTyped@ef7406a
Pull Request Test Coverage Report for Build 3914
💛 - Coveralls |
thanks for your PR, LGTM 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I have just one question:
@AndrewLeedham thanks! |
@kulshekhar will this trigger an npm release? |
@AndrewLeedham no. I'll have to do that manually. I'll try to do it later today |
@@ -1,12 +1,15 @@ | |||
import { TransformOptions, TransformedSource } from '@jest/transform/build/types' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please send PRs for any types you need that are not exported at the top level of the module. Reaching into build/
is not supported and can break at any time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean FR and PRs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull requests 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, we already export TransformOptions
at least. TransformedSource
is not exported though (ReturnType<Transformer['process']>
is clunky), so PR for that is welcome
https://www.runpkg.com/?@jest/transform@25.2.4/build/index.d.ts
A lot of the Jest typings were moved into the core repo rather than the
@types/jest
definitions. See DefinitelyTyped/DefinitelyTyped@ef7406afixes: #1362