Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jest 25 type definitions #1363

Merged
merged 1 commit into from Jan 29, 2020

Conversation

AndrewLeedham
Copy link
Contributor

A lot of the Jest typings were moved into the core repo rather than the @types/jest definitions. See DefinitelyTyped/DefinitelyTyped@ef7406a

fixes: #1362

A lot of the Jest typings were moved into the core repo rather than the `@types/jest` definitions. See DefinitelyTyped/DefinitelyTyped@ef7406a
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3914

  • 7 of 7 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.286%

Totals Coverage Status
Change from base Build 3913: 0.0%
Covered Lines: 1075
Relevant Lines: 1133

💛 - Coveralls

@ahnpnl
Copy link
Collaborator

ahnpnl commented Jan 28, 2020

thanks for your PR, LGTM 👍

Copy link
Owner

@kulshekhar kulshekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I have just one question:

package.json Show resolved Hide resolved
@kulshekhar kulshekhar merged commit d290db0 into kulshekhar:master Jan 29, 2020
@kulshekhar
Copy link
Owner

@AndrewLeedham thanks!

@AndrewLeedham
Copy link
Contributor Author

@kulshekhar will this trigger an npm release?

@kulshekhar
Copy link
Owner

@AndrewLeedham no. I'll have to do that manually. I'll try to do it later today

@@ -1,12 +1,15 @@
import { TransformOptions, TransformedSource } from '@jest/transform/build/types'
Copy link
Contributor

@SimenB SimenB Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please send PRs for any types you need that are not exported at the top level of the module. Reaching into build/ is not supported and can break at any time

Copy link
Collaborator

@ahnpnl ahnpnl Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean FR and PRs ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull requests 🙂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, we already export TransformOptions at least. TransformedSource is not exported though (ReturnType<Transformer['process']> is clunky), so PR for that is welcome

https://www.runpkg.com/?@jest/transform@25.2.4/build/index.d.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest @types/jest incompatible
5 participants