Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let babel-jest handle loading babel config #1370

Merged
merged 8 commits into from Feb 3, 2020
Merged

Let babel-jest handle loading babel config #1370

merged 8 commits into from Feb 3, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Feb 3, 2020

Closes #1341

Note: this needs to be well tested because it looks to me like a breaking change.

@coveralls
Copy link

coveralls commented Feb 3, 2020

Pull Request Test Coverage Report for Build 3951

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 90.458%

Totals Coverage Status
Change from base Build 3950: 0.2%
Covered Lines: 1066
Relevant Lines: 1122

💛 - Coveralls

Copy link
Owner

@kulshekhar kulshekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. What problems do you anticipate with this change @ahnpnl ?

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Feb 3, 2020

we now only collect any babel configs we can and pass them to babel-jest invocation so I'm not sure if this might break anything, just that is my concern only.

@kulshekhar
Copy link
Owner

ok. Let's merge this in then. I'll push a new release later today after that

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Feb 3, 2020

ok let's proceed like that

@kulshekhar kulshekhar merged commit a303981 into kulshekhar:master Feb 3, 2020
@kulshekhar
Copy link
Owner

pushing a release out shortly.

aside: @ahnpnl when you get the chance, could you please check the message I've sent on slack?

@SimenB
Copy link
Contributor

SimenB commented Feb 5, 2020

Yup, letting babel-jest handle all loading of babel config should be correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BabelConfig with rootMode: "upward" not loading babel config files
4 participants