Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve diagnostics message #1444

Merged
merged 2 commits into from Mar 25, 2020
Merged

chore: improve diagnostics message #1444

merged 2 commits into from Mar 25, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Mar 24, 2020

closes #1441

@ahnpnl ahnpnl requested a review from kulshekhar March 24, 2020 18:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4158

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.645%
Totals Coverage Status
Change from base Build 4157: 0.0%
Covered Lines: 1117
Relevant Lines: 1154
💛 - Coveralls

@ahnpnl ahnpnl merged commit 96cd9b3 into kulshekhar:master Mar 25, 2020
@ahnpnl ahnpnl deleted the improve-diagnostics-message branch March 25, 2020 08:20
@thinkh thinkh mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable message about diagnostics
3 participants
@ahnpnl @coveralls @kulshekhar