Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): use original jest config object #1511

Merged
merged 1 commit into from Apr 8, 2020
Merged

fix(config): use original jest config object #1511

merged 1 commit into from Apr 8, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 7, 2020

Summary

Jest config string doesn't contain the correct value for testRegex therefore micromatch in compiler failed to validate file name against this value, see related issue reported for jest team to handle: jestjs/jest#9778.

This PR switches to use original jest config object to get the correct value for testRegex, close #1509

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@coveralls
Copy link

coveralls commented Apr 7, 2020

Pull Request Test Coverage Report for Build 4376

  • 22 of 22 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 92.944%

Totals Coverage Status
Change from base Build 4371: 0.2%
Covered Lines: 1160
Relevant Lines: 1195

💛 - Coveralls

@ahnpnl ahnpnl marked this pull request as ready for review April 7, 2020 22:37
@ahnpnl ahnpnl requested a review from kulshekhar as a code owner April 7, 2020 22:37
@ahnpnl ahnpnl merged commit 4f0bb33 into kulshekhar:master Apr 8, 2020
@ahnpnl ahnpnl deleted the fix-issue-1509 branch April 8, 2020 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Expected pattern to be a non-empty string from picomatch
3 participants