Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compiler): improve performance for isolatedModules: false #1558

Merged
merged 7 commits into from Apr 22, 2020
Merged

chore(compiler): improve performance for isolatedModules: false #1558

merged 7 commits into from Apr 22, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 22, 2020

Summary

Improve performance for isolatedModules: false by only creating LanguageService instance with limited amount of initial files.

Because when creating LanguageService instance with fileNames from tsconfig, often this fileNames includes all the files in the project which makes internal TypeScript performs scanning and reading the unnecessary files. This is not optimal because it will create lots of I/O threads which then impact heavily on the performance.

This PR should help #1115 and all related performance issues by somewhere around 30% improvement in speed.

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner April 22, 2020 11:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4504

  • 48 of 48 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 92.893%

Totals Coverage Status
Change from base Build 4502: 0.05%
Covered Lines: 1074
Relevant Lines: 1109

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants