Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading from v25.4.0 to v25.5.0 breaks custom types #1608

Closed
TheDutchCoder opened this issue May 7, 2020 · 5 comments 路 Fixed by #1606
Closed

Upgrading from v25.4.0 to v25.5.0 breaks custom types #1608

TheDutchCoder opened this issue May 7, 2020 · 5 comments 路 Fixed by #1606
Labels
馃悰 Bug Confirmed Bug is confirmed

Comments

@TheDutchCoder
Copy link

馃悰 Bug Report

After upgrading to 25.5.0, any of my modules that use custom interfaces/types stored in types.ts in the root are no longer found.

Probably related to #1604 but not exclusive to Vue files.

Downgrading to 25.4.0 makes it work again.

To Reproduce

Steps to reproduce the behavior:

  • Use a custom types file with a custom interface
  • Use the interface in a module
  • Run a test on it

Expected behavior

Custom types to work

envinfo

System:
    OS: Mac OS Mojave

Npm packages:
    jest: 25.5.4
    ts-jest: 25.5.0
    typescript: 3.8.3
    babel(optional): 7.9.6
@TheDutchCoder TheDutchCoder added Bug Report Needs Repo Need a minimium repository to reproduce the problem Needs Triage labels May 7, 2020
@ahnpnl
Copy link
Collaborator

ahnpnl commented May 7, 2020

Hi, this is mentioned in CHANGELOG as breaking change. Migration step is defined there as well.

However, due to the request in #1604 , we will revert the change.

@ahnpnl
Copy link
Collaborator

ahnpnl commented May 7, 2020

you can try alpha version #1604 (comment) to see if it fixes your issue

@TheDutchCoder
Copy link
Author

TheDutchCoder commented May 7, 2020

Ah thanks, that alpha version works for me!

Feel free to close this issue if you think that's appropriate.

@ahnpnl
Copy link
Collaborator

ahnpnl commented May 7, 2020

Close via #1606

@ahnpnl ahnpnl closed this as completed May 7, 2020
@ahnpnl
Copy link
Collaborator

ahnpnl commented May 9, 2020

25.5.1 is out

@ahnpnl ahnpnl added the Confirmed Bug is confirmed label Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悰 Bug Confirmed Bug is confirmed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants