Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typing): don't mark BabelConfig as internal type #1667

Merged
merged 1 commit into from May 21, 2020
Merged

fix(typing): don't mark BabelConfig as internal type #1667

merged 1 commit into from May 21, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented May 21, 2020

Summary

Close #1666

Test plan

Test against the repo in #1666

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Also lock typescript at 3.x in package.json

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner May 21, 2020 08:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4899

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.826%

Totals Coverage Status
Change from base Build 4898: 0.0%
Covered Lines: 1060
Relevant Lines: 1095

💛 - Coveralls

@ahnpnl ahnpnl merged commit 558c307 into kulshekhar:master May 21, 2020
@ahnpnl ahnpnl deleted the expose-babel-config-type branch May 21, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ts-jest/dist/types.d.ts:15:38 - error TS2304: Cannot find name 'BabelConfig'.
3 participants