Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add support for multiple paths in module name mapper #1690

Merged
merged 2 commits into from May 29, 2020

Conversation

OrkhanAlikhanov
Copy link
Contributor

Summary

Closes #1072

Does this PR introduce a breaking change?

  • Yes
  • No

@coveralls
Copy link

coveralls commented May 27, 2020

Pull Request Test Coverage Report for Build 4990

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 92.822%

Totals Coverage Status
Change from base Build 4988: 0.004%
Covered Lines: 1065
Relevant Lines: 1100

💛 - Coveralls

@ahnpnl
Copy link
Collaborator

ahnpnl commented May 27, 2020

hi, thank you for your PR. In general the PR LGTM.

Just extra requests:

  • Would you please add extra tests to e2e ? In e2e, there are e2e tests as well as tests on external repos. I think this kind of feature deserves some e2e tests.

  • Would you please adjust documentations about the usage of this function pathToModuleNameMapper as well ? You can find documentations in docs/user/config/index.md

@OrkhanAlikhanov
Copy link
Contributor Author

I have no idea how an e2e test should look like. Also I don't think there is any need for updating docs because it never explained the method's implementation details.

@ahnpnl
Copy link
Collaborator

ahnpnl commented May 28, 2020

You can put the example of using this function in external-repos. In that folder, there are several independent projects. You can adjust one project to have this function in use. That would be sufficient enough.

To test the changes in external-repos, you can run test:external-repos script which can be found in package.json

Regarding to documentation, it can be excluded from this PR.

@OrkhanAlikhanov
Copy link
Contributor Author

I added e2e tests, thanks for guiding me. Also rebased the master. I hope it passes the quality control this time :]

Copy link
Collaborator

@ahnpnl ahnpnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍 LGTM
@kulshekhar please have a look once

Copy link
Owner

@kulshekhar kulshekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well. Thanks @OrkhanAlikhanov 😃

@ahnpnl ahnpnl merged commit a727bd5 into kulshekhar:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

moduleNameMapper doesn't handle multiple paths
4 participants