Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): invalidate cache when other options in tsconfig change #1788

Merged
merged 3 commits into from Jul 9, 2020
Merged

fix(config): invalidate cache when other options in tsconfig change #1788

merged 3 commits into from Jul 9, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Jul 9, 2020

Summary

At the moment, only compilerOptions in tsconfig.json is considered in cache key. However, if users change other options like include or exclude, the cache isn't invalidated. Since include/exclude impacts on performance with ts-jest, it makes sense to include them into cache key.

This PR is to invalidate cache whenever other options (include/exclude/projectReferences) from tsconfig.json change

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner July 9, 2020 09:01
@coveralls
Copy link

coveralls commented Jul 9, 2020

Pull Request Test Coverage Report for Build 5310

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 92.721%

Totals Coverage Status
Change from base Build 5308: -0.1%
Covered Lines: 1056
Relevant Lines: 1091

💛 - Coveralls

@ahnpnl ahnpnl merged commit 6948855 into kulshekhar:master Jul 9, 2020
@ahnpnl ahnpnl deleted the burst-cache branch July 9, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants