Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow opt-out version checking by environment variable #1821

Merged
merged 1 commit into from Jul 21, 2020
Merged

feat: allow opt-out version checking by environment variable #1821

merged 1 commit into from Jul 21, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Jul 21, 2020

Summary

  • Allow opt-out version checking warning message via environment variable TS_JEST_DISABLE_VER_CHECKER

  • Adjust documentation

Close #1774

Test plan

Added unit test and e2e test. Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner July 21, 2020 15:08
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5409

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 92.737%
Totals Coverage Status
Change from base Build 5408: 0.02%
Covered Lines: 1058
Relevant Lines: 1093
💛 - Coveralls

@ahnpnl ahnpnl merged commit e6b42fc into kulshekhar:master Jul 21, 2020
@ahnpnl ahnpnl deleted the opt-out-version-checking branch July 21, 2020 16:42
@ahnpnl ahnpnl mentioned this pull request Aug 2, 2020
Closed
3 tasks
@fubhy
Copy link

fubhy commented Aug 11, 2020

Hi @ahnpnl, thanks for merging this. Would you mind tagging a release with this included or do you know when you are going to tag the next release?

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Aug 11, 2020

hi @fubhy ya ts-jest can have release today :)

@ahnpnl ahnpnl mentioned this pull request Oct 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have an option for opting out of the version checker messages?
4 participants
@ahnpnl @coveralls @fubhy @kulshekhar