Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): pathsToModuleNameMapper resolve path mapping with path.join #1969

Merged
merged 1 commit into from Sep 19, 2020
Merged

fix(utils): pathsToModuleNameMapper resolve path mapping with path.join #1969

merged 1 commit into from Sep 19, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Sep 19, 2020

Summary

Closes #1968

Test plan

adjusted unit tests and e2e tests, green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5942

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 93.214%
Totals Coverage Status
Change from base Build 5941: 0.003%
Covered Lines: 1137
Relevant Lines: 1171
💛 - Coveralls

@ahnpnl ahnpnl merged commit 81fce4c into kulshekhar:master Sep 19, 2020
@ahnpnl ahnpnl deleted the fix-path-mapper branch September 19, 2020 09:20
@splincode splincode mentioned this pull request Sep 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] pathsToModuleNameMapper prefix wrong path resolve
3 participants
@ahnpnl @coveralls @kulshekhar