Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make warning message for nodejs ts target version mismatch configurable #2032

Closed
herschel666 opened this issue Oct 16, 2020 · 2 comments
Closed
Labels
馃殌 Feature Request new suggested feature

Comments

@herschel666
Copy link

馃殌 Feature Proposal

In case the output of ts-jest is channeled through Babel anyways, because ts-jest is an optional part of the Jest setup, the warning message regarding a mismatching nodejs target doesn't really make sense. In this case it would be nice to have an option to disable it.

Motivation

My team and I are maintaining Hops, which ships with a Jest-preset. This again contains the optional ts-jest (mentioned above) and will always run the code through Babel. So this warning is unnecessary and confusing for users of Hops.

@herschel666 herschel666 added the 馃殌 Feature Request new suggested feature label Oct 16, 2020
@ahnpnl
Copy link
Collaborator

ahnpnl commented Oct 16, 2020

The warning message was fixed in #1729 which is in 26.1.1 . Or I understood your case is different ?

@herschel666
Copy link
Author

Sorry. Just checked again with the project, that showed the warning, and it turned out that there's been a misconfiguration with the custom Jest preset, so that the babelConfig-option got lost. After fixing that, the warning disappeared. 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃殌 Feature Request new suggested feature
Projects
None yet
Development

No branches or pull requests

2 participants