New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): expose several typings as public apis #2054

Merged

ahnpnl merged 1 commit into kulshekhar:master from ahnpnl:typings

Oct 22, 2020

Collaborator

ahnpnl commented Oct 22, 2020 •

edited

Summary

Expose several properties in ConfigSet
Expose JsonableValue and some json utils
Expose updateOutput function in compiler

TypeScript doesn't allow subclass to use parent class getters so we have to convert public getters to public properties, see microsoft/TypeScript#338

Test plan

Green CI

Does this PR introduce a breaking change?

Yes
No

Other information

N.A.


          feat(config): expose several typings as public apis

007bc7f

ahnpnl requested a review from kulshekhar as a code owner

October 22, 2020 13:15

coveralls commented Oct 22, 2020

Pull Request Test Coverage Report for Build 6267

22 of 22 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 93.654%

Totals
Change from base Build 6266:	-0.04%
Covered Lines:	1018
Relevant Lines:	1047

💛 - Coveralls

kulshekhar approved these changes

View reviewed changes

ahnpnl merged commit 3b6b705 into kulshekhar:master

ahnpnl deleted the typings branch

October 22, 2020 14:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment