Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding @type/xxx dependency does not clear the cache #785

Closed
developer239 opened this issue Oct 2, 2018 · 5 comments · Fixed by #795
Closed

adding @type/xxx dependency does not clear the cache #785

developer239 opened this issue Oct 2, 2018 · 5 comments · Fixed by #795
Labels
🐛 Bug
Milestone
23.10.4

Comments

@developer239
Copy link

Issue

CircleCI build failing after updating from 23.1.4 to 23.10.0.

Expected behavior

CircleCI build should not fail.

Debug log:

PR: developer239/localized-graphql-koa-typescript#12
CircleCI log:
screenshot 2018-10-02 at 14 05 51

Minimal repo

https://github.com/developer239/localized-graphql-koa-typescript
@huafu
Copy link
Collaborator

huafu commented Oct 2, 2018

@developer239 I think it's clear what's failing here, the message is explicit. You have to fix the typing issue, or disable the diagnostics.

Documentation can be found there https://kulshekhar.github.io/ts-jest/

@huafu huafu closed this as completed Oct 2, 2018
@huafu
Copy link
Collaborator

huafu commented Oct 2, 2018 •
edited

@developer239 sorry that you read it like that, didn't mean that at all. Worst I can mean is that you wouldn't read. You don't know how many people submit issues because they don't read the error message.

Cloning your repo now and checking.

Edit: btw, you username didn't help :-p

@huafu huafu reopened this Oct 2, 2018
@huafu
Copy link
Collaborator

huafu commented Oct 2, 2018

@developer239 after installing some types, you have to yarn jest --clearCache, I guess that is an issue to report. I'm going to update this issue title to reflect that. There are then some other issues coming up, related to typings. I guess knowing this you can go on fixing the others. If you have any other issue unrelated, please open a new one and/or find live help on our slack channel https://bit.ly/ts-jest-slack. Sorry again for closing this too quickly, it looked too obvious.

@huafu huafu closed this as completed Oct 2, 2018
@huafu huafu reopened this Oct 2, 2018
@huafu huafu changed the title Breaks when updating from 23.1.4 to 23.10.0 adding @type/xxx dependency does not clear the cache Oct 2, 2018
@huafu huafu added the 🐛 Bug label Oct 2, 2018
@huafu huafu added this to the 23.10.4 milestone Oct 2, 2018
@developer239
Copy link
Author

@huafu Adding the dependency, clearing cache and fixing some additional typescript error works for me.

@huafu
Copy link
Collaborator

huafu commented Oct 2, 2018

@developer239 either leave this open or create another issue about the clear cache necessary after adding @types deps. This is actually an issue 😉

@huafu huafu reopened this Oct 3, 2018
huafu added a commit to huafu/ts-jest that referenced this issue Oct 6, 2018
@huafu
fix(cache): adds project's dep versions to cache key
e7efc96 
Includes the real version of each dependency of the containing project
in the cache key digest calculation.

Closes kulshekhar#785
@huafu huafu closed this as completed in 6cacbea Oct 6, 2018
@huafu huafu mentioned this issue Oct 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug
Projects
None yet
Milestone
23.10.4
Development

Successfully merging a pull request may close this issue.

chore(release): 23.10.4 huafu/ts-jest
2 participants
@huafu @developer239