Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn build not working anymore #452

Open
alexandre-jalat opened this issue Apr 15, 2018 · 5 comments
Open

Yarn build not working anymore #452

alexandre-jalat opened this issue Apr 15, 2018 · 5 comments

Comments

@alexandre-jalat
Copy link

Hey guys,

I've tried to deploy a new api using this wonderful boilerplate and seems that the package.json have been changed.

Yarn build do not work anymore; is not found.

What is the new way to compile to ES5 for production use ? The readme.md need to be change BTW.

Thanks,
Tim

@roymina
Copy link

roymina commented Apr 26, 2018

I checked commits before and found this:

  "scripts": {
    "start": "gulp serve",
    "start:debug": "cross-env DEBUG=express-mongoose-es6-rest-api:* yarn start",
    "build": "gulp",
    "lint": "esw *.js server config --color",
    "lint:watch": "yarn lint -- --watch",
    "precommit": "yarn lint && yarn test",
    "test": "cross-env NODE_ENV=test ./node_modules/.bin/mocha --ui bdd --reporter spec --colors --compilers js:babel-core/register server/tests --recursive",
    "test:watch": "yarn test -- --watch",
    "test:coverage": "cross-env NODE_ENV=test ./node_modules/.bin/istanbul cover _mocha -- --ui bdd --reporter spec --colors --compilers js:babel-core/register server/tests --recursive",
    "test:check-coverage": "yarn test:coverage && istanbul check-coverage",
    "report-coverage": "coveralls < ./coverage/lcov.info"
  }

seems "build":"gulp", command has been removed in recent commits

@danieloquendo
Copy link

Idea of why of sample error with the yarn build?

@kalagin
Copy link

kalagin commented Jun 4, 2018

Same problem

@alfonmga
Copy link

@kunalkapadia

@xAt0mZ
Copy link

xAt0mZ commented Jul 5, 2018

Gulp has been removed with commit c669d33.
Babel (transpilation to es5) has been removed with commit 9bb0899.

Seems @kunalkapadia wants to avoid transpiling the code to es5, as es6 is the norm now and you don't need to bundle all your project into a single file (according to internet, for example here ).

For a production deployment process, take a look at https://blog.risingstack.com/node-hero-deploy-node-js-heroku-docker/ (tutorial referenced in commit 590a124, and Heroku suggested in the previous reddit link).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants