Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0-value flows are found in other flows #102

Open
TheoLaperrouse opened this issue Aug 10, 2023 · 0 comments
Open

0-value flows are found in other flows #102

TheoLaperrouse opened this issue Aug 10, 2023 · 0 comments

Comments

@TheoLaperrouse
Copy link

Hello @kurkle,

I love this library, it allows you to create beautiful sankeys very easily, we've been using this library for 2 years and we are pleased with the progress that has been made since then.

Problem

There seems to be a problem when the flows are equal to 0 on 'final' branch, the 'BUG' branch is inside the 'DA' branch.

image

Here's a codeSandbox that summarises the problem:

https://codesandbox.io/s/misty-sun-574jf5?file=/src/index.js

Expected

I expect the 'BUG' branch to be appart from the 'DA' Branch

One possibility on our side would be to add a tiny quantity so that the final branch does not end up in the middle of another final branch. (as 'NOTOVERLAPPING' branch). But this solution doesn't seem very relevant and doesn't suit me. Is it a bug, have you some advices to fix this?

Thanks,
Théo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant