Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dividers option to be removed #173

Open
stockiNail opened this issue Dec 12, 2022 Discussed in #170 · 0 comments
Open

Dividers option to be removed #173

stockiNail opened this issue Dec 12, 2022 Discussed in #170 · 0 comments
Labels
breaking change A change which needs a major version because not compatible with previous versions
Milestone

Comments

@stockiNail
Copy link
Collaborator

Discussed in #170

Originally posted by stockiNail December 12, 2022
Having a look to the dividers option, it is not clear to me if the current bahvior is the wished one or not.

At the moment, setting the dividers option, the box is splitted by 2, ignoring the amount of subelements.

In the sample (https://chartjs-chart-treemap.pages.dev/samples/dividers.html), the passed data are the following:

const data = [
  {category: 'main', value: 1},
  {category: 'main', value: 2},
  {category: 'main', value: 3},
  {category: 'other', value: 4},
  {category: 'other', value: 5},
];

and my expectation, maybe wrong, grouping by category, is to have 2 boxes with 2 dividers for main and 1 for other. Instead, there is 1 divider for main and 1 for other.

@stockiNail stockiNail added the breaking change A change which needs a major version because not compatible with previous versions label Dec 12, 2022
@stockiNail stockiNail added this to the 3.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A change which needs a major version because not compatible with previous versions
Projects
None yet
Development

No branches or pull requests

1 participant