Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow per message compression for websocket #1734

Closed
scottinet opened this issue Jul 24, 2020 · 0 comments · Fixed by #2029
Closed

Allow per message compression for websocket #1734

scottinet opened this issue Jul 24, 2020 · 0 comments · Fixed by #2029
Assignees

Comments

@scottinet
Copy link
Contributor

scottinet commented Jul 24, 2020

Feature description

Per message compression is currently explicitly deactivated server-side due to catastrophic memory fragmentation problems encountered in Node.js when heavily using zlib (nodejs/node#8871).

A solution seems to have been found and merged a few days ago (nodejs/node#34048). We need to keep an eye on it: if this lands in Node.js 12, we could then allow per-message compression in websockets.

If we do though, this would need to be deactivated by default. A new flag in Kuzzle's configuration files would allow to activate that feature, with a proper documentation explaining from which version of node.js that option can be safely used.

@Aschen Aschen changed the title Feature Request: Allow per message compression for websocket Allow per message compression for websocket Aug 6, 2020
@scottinet scottinet self-assigned this Mar 11, 2021
@Leodau Leodau linked a pull request Mar 25, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant