Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mappings update should trigger a reindex #1915

Closed
scottinet opened this issue Dec 18, 2020 · 0 comments
Closed

Mappings update should trigger a reindex #1915

scottinet opened this issue Dec 18, 2020 · 0 comments

Comments

@scottinet
Copy link
Contributor

Feature description

When updating mappings on a collection to add new fields, if there are existing documents with those new fields, they still won't be searchable. To include those documents, a reindex should be triggered (see here: https://www.elastic.co/guide/en/elasticsearch/reference/7.9/docs-update-by-query.html#picking-up-a-new-property)

Our mappings update actions should probably do that by default.

Example usecase

Create a collection with dynamic: 'false' and no mappings.
Add a few documents in it.
Then add mappings to describe the fields in the added documents.

Expected: running a document:search in the collection should return the searched documents.
Obtained result: documents existing prior to the mappings update do not appear in the results without a manual reindex.

@Leodau Leodau self-assigned this Mar 5, 2021
@Leodau Leodau removed their assignment Mar 14, 2021
@clementbolin clementbolin self-assigned this Apr 12, 2022
@clementbolin clementbolin linked a pull request Apr 16, 2022 that will close this issue
@rolljee rolljee closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants