Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ECDSA signatures #5

Open
kylef opened this issue Apr 5, 2015 · 10 comments
Open

Support ECDSA signatures #5

kylef opened this issue Apr 5, 2015 · 10 comments

Comments

@kylef
Copy link
Owner

kylef commented Apr 5, 2015

No description provided.

@ColtonProvias
Copy link

Is there any possibility of making use of OpenSSL or LibreSSL for this?

@kylef
Copy link
Owner Author

kylef commented Dec 2, 2016

@ColtonProvias I wouldn't be against it. It would be nice to use a known security library under the hood. Providing we can 1) make installation simple, 2) support all Apple platforms, Linux, fBSD.

@benaubin
Copy link

benaubin commented Jan 16, 2017

@kylef I'm attempting to add support for ES256, using Apple's built in SecKeyRawSign (for Secure Enclave). Fair warning, the API doesn't work with MacOS, but works with all other platforms (iOS, tvOS and watchOS).

Would you like me to submit a PR?

@kylef
Copy link
Owner Author

kylef commented Jan 16, 2017

@penne12 Do you think you think we could support ES256 on iOS, tvOS and watchOS using SecKeyRawSign and fallback to the current behaviour by not supporting ES256 on other platforms, this will keep the current support on Linux and macOS. If so I'd love a pull request.

@benaubin
Copy link

@kylef I could add in a build directive, maybe?

Not sure, I'm fairly new to the language (and I haven't worked with compiled languages in a while, either)

@kylef
Copy link
Owner Author

kylef commented Jan 16, 2017

@penne12 yes that would work. Sounds great!

@kylef
Copy link
Owner Author

kylef commented Jan 16, 2017

@penne12 If you hit any problems, feel free to make a PR with your work in progress and I can give you pointers if you get stuck with anything.

@benaubin
Copy link

@kylef Sounds good.

@darer
Copy link

darer commented May 2, 2017

@kylef, @benaubin any progress on this? ES256 is what I need to use.

@bengottlieb
Copy link

@benaubin Just a re-request for ES256 support, if you've got it working. Thanks!

Repository owner locked and limited conversation to collaborators Jul 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants