Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIRule reconcile function refactoring #1016

Open
6 tasks
Tracked by #939
strekm opened this issue Apr 25, 2024 · 0 comments
Open
6 tasks
Tracked by #939

APIRule reconcile function refactoring #1016

strekm opened this issue Apr 25, 2024 · 0 comments
Labels
area/api-gateway Issues or PRs related to api-gateway kind/feature Categorizes issue or PR as related to a new feature.

Comments

@strekm
Copy link
Collaborator

strekm commented Apr 25, 2024

Description

Introduction of APIRule v1beta2 added complexity to main reconcile function that needs to be addressed before adding extAuth handler.

ACs:

  • removed complexity from reconcile function
  • make implementation easy to extend with another handler
  • make reconcile function version aware

Additional info

  • Configuration for immutable fields can be achieved by using CEL validation:
    // +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
    This might be useful to support conversion from v1beta2 to 1 without need for preserveUnknownFields.

DoD:

  • Provide unit and integration tests.
    - [ ] Provide documentation.
  • Verify if the solution works for both open-source Kyma and SAP BTP, Kyma runtime.
    - [ ] If you changed the resource limits, explain why it was needed.
  • Verify that your contributions don't decrease code coverage. If they do, explain why this is the case.
    - [ ] Add release notes.

Attachments
part of: #939

@strekm strekm added kind/feature Categorizes issue or PR as related to a new feature. area/api-gateway Issues or PRs related to api-gateway labels Apr 25, 2024
@strekm strekm mentioned this issue Apr 25, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api-gateway Issues or PRs related to api-gateway kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant