-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Provisioner cluster role binding creation process #2858
Comments
This issue or PR has been automatically marked as stale due to the lack of recent activity. This bot triages issues and PRs according to the following rules:
You can:
If you think that I work incorrectly, kindly raise an issue with the problem. /lifecycle stale |
This issue or PR has been automatically closed due to the lack of activity. This bot triages issues and PRs according to the following rules:
You can:
If you think that I work incorrectly, kindly raise an issue with the problem. /close |
@kyma-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue or PR has been automatically closed due to the lack of activity. This bot triages issues and PRs according to the following rules:
You can:
If you think that I work incorrectly, kindly raise an issue with the problem. /close |
@kyma-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@koala7659 : could we keep this closed as the provision has reached End-Of-Life soon? |
@tobiscr I think we should close this. This code is being gradually removed (. https://github.com/kyma-project/control-plane/pull/3438/files) and soon will be fully replaced with new |
This is a Follow Up story after fixing issue 1912:
Description:
Provisioner is responsible for initial setup of the created Kyma Runtime.
There was once introduced functionality to dynamically update list of runtime administrators by the Provisioner during Upgrade Shoot API call. This code was supposed to create and label required
ClusterRoles
andClusterRoleBindings
to generate correct set of administrators accounts during creation/update of the managed Kyma Runtime.Code responsible for creating ClusterRoles and ClusterRole bindings can be found here:
https://github.com/kyma-project/control-plane/blob/main/components/provisioner/internal/operations/stages/provisioning/create_operators_bindings.go
Problems with code:
reconciler.kyma-project.io/managed-by=reconciler
Suggested solution:
A. If Provisioner is not able to dynamically update runtime bindings - consider removing execution path for shoot upgrade.
B. If Provisioner is somehow able to dynamically update runtime bindings - Consider refactoring of the code by splitting it into two separate operations executed on different stages of Kyma runtime
reconciler.kyma-project.io/managed-by=reconciler
for createdClusterRules
[Moved from Provisioner to KIM]
The text was updated successfully, but these errors were encountered: