Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor KEB after Reconciler removal #536

Open
2 of 10 tasks
PK85 opened this issue Jul 11, 2023 · 4 comments
Open
2 of 10 tasks

Refactor KEB after Reconciler removal #536

PK85 opened this issue Jul 11, 2023 · 4 comments
Assignees
Labels
2023-Q4 Planned for Q4 2023 area/control-plane Related to all activities around Kyma Control Plane size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Comments

@PK85
Copy link

PK85 commented Jul 11, 2023

Description
This ticket is an outcome of the TASK.

AC

Note

@PK85 PK85 added 2023-Q4 Planned for Q4 2023 area/control-plane Related to all activities around Kyma Control Plane labels Jul 11, 2023
@PK85 PK85 changed the title Cleanup KEB after Reconciler removal Refactor KEB after Reconciler removal Jul 11, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Sep 9, 2023

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 9, 2023
@kyma-bot
Copy link
Contributor

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

@kyma-bot
Copy link
Contributor

@kyma-bot: Closing this issue.

In response to this:

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@szwedm szwedm removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2024
@PK85 PK85 reopened this Feb 27, 2024
@PK85 PK85 transferred this issue from kyma-project/control-plane Mar 7, 2024
@PK85 PK85 added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 8, 2024
@KsaweryZietara KsaweryZietara self-assigned this May 10, 2024
This was referenced May 10, 2024
@MarekMichali MarekMichali self-assigned this May 22, 2024
@MarekMichali MarekMichali removed their assignment May 27, 2024
@piotrmiskiewicz
Copy link
Member

Ideas, how to avoid problems with ArgoCD:

  1. Change kind: to kind_ArgoSucks:, then implement a config/reader_for_argo which do a string.replace operation on the input. Example
runtimeConfiguration: |-
    own_cluster:
      kyma-template: |-
        apiVersion: operator.kyma-project.io/v1beta2
        kind_ArgoSucks: Kyma
        metadata:
          labels:
            "operator.kyma-project.io/managed-by": "lifecycle-manager"
        name: tbd
        namespace: kcp-system
      spec:
        channel: fast
        modules: []
      additional-components: []
    default:
      kyma-template: |-
        apiVersion: operator.kyma-project.io/v1beta2
        kind_ArgoSucks: Kyma
        metadata:
          labels:
            "operator.kyma-project.io/managed-by": "lifecycle-manager"
        name: tbd
        namespace: kcp-system
      spec:
        channel: fast
        modules:
          - name: api-gateway
          - name: istio
          - name: btp-operator
      additional-components: []

Disadvantage: Ugly config
2. Configure kind: Kyma outside of the main config:

kymaTemplateKind: Kyma
runtimeConfiguration: |-
    own_cluster:
      kyma-template: |-
        apiVersion: operator.kyma-project.io/v1beta2
        metadata:
          labels:
            "operator.kyma-project.io/managed-by": "lifecycle-manager"
        name: tbd
        namespace: kcp-system
      spec:
        channel: fast
        modules: []
      additional-components: []
    default:
      kyma-template: |-
        apiVersion: operator.kyma-project.io/v1beta2
        metadata:
          labels:
            "operator.kyma-project.io/managed-by": "lifecycle-manager"
        name: tbd
        namespace: kcp-system
      spec:
        channel: fast
        modules:
          - name: api-gateway
          - name: istio
          - name: btp-operator
      additional-components: []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023-Q4 Planned for Q4 2023 area/control-plane Related to all activities around Kyma Control Plane size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

No branches or pull requests

6 participants