-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix goroutine leak #709
Comments
One way to test it on dev without promoting it to stage is to add the We should also create a custom KEB release from a fork for this testing scenario, by building and hosting the KEB chart there as we do upstream, without interfering with the upstream KEB release process. After successful testing, everything should be merged form the fork to upstream and released there. |
The leak is somewhere in |
Creating |
We decide to leave this issue for now, as it only occurs on dev. |
The number of goroutines is constantly growing. It looks like the AvS client (http with oauth) is created for every http call. It should be changed to use shared one. The initial AvS implementation was done this way, but there was a problem with token refreshing (see https://github.com/kyma-project/control-plane/pull/268/files).
AC:
In case of extracting AvShttp client to shared one - test the implementation for more than 24 h to check if it works fine (token refreshing etc.)
The text was updated successfully, but these errors were encountered: