Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated ControllerManagerConfig #1375

Closed
1 task done
ruanxin opened this issue Mar 7, 2024 · 0 comments · Fixed by kyma-project/template-operator#176 or #1476
Closed
1 task done

Remove deprecated ControllerManagerConfig #1375

ruanxin opened this issue Mar 7, 2024 · 0 comments · Fixed by kyma-project/template-operator#176 or #1476
Assignees
@nesmabadr
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@ruanxin
Copy link
Contributor

ruanxin commented Mar 7, 2024 •
edited by nesmabadr

Description

The ComponentConfig has been deprecated in the Controller-Runtime since its version 0.15.0. More info Moreover, it has undergone breaking changes and is no longer functioning as intended. As a result, Kubebuilder, which heavily relies on the Controller Runtime, has also deprecated this feature, no longer guaranteeing its functionality from version 3.11.0 onwards. You can find additional details on this issue here.

Reasons

clean up tech debt

Acceptance Criteria

  • everything in kustomize profile related to ControllerManagerConfig get removed

Feature Testing

No response

Testing approach

No response

Attachments

No response
@ruanxin ruanxin added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 7, 2024
@nesmabadr nesmabadr self-assigned this Apr 16, 2024
This was referenced Apr 17, 2024
Merged
Merged
@nesmabadr nesmabadr removed their assignment Apr 17, 2024
@c-pius c-pius self-assigned this Apr 17, 2024
kyma-bot pushed a commit to kyma-project/template-operator that referenced this issue Apr 17, 2024
@nesmabadr
chore: Remove deprecated ControllerManagerConfig (#176)
4520c3d 
<!-- Thank you for your contribution. Before you submit the pull
request:
1. Follow contributing guidelines, templates, the recommended Git
workflow, and any related documentation.
2. Read and submit the required Contributor Licence Agreements
(https://github.com/kyma-project/community/blob/main/CONTRIBUTING.md#agreements-and-licenses).
3. Test your changes and attach their results to the pull request.
4. Update the relevant documentation.

If the pull request requires a decision, follow the [decision-making
process](https://github.com/kyma-project/community/blob/main/governance.md)
and replace the PR template with the [decision record
template](https://github.com/kyma-project/community/blob/main/.github/ISSUE_TEMPLATE/decision-record.md).
-->

**Description**

Changes proposed in this pull request:

- Remove deprecated ControllerManagerConfig

**Related issue(s)**
Resolves kyma-project/lifecycle-manager#1375
@c-pius c-pius assigned nesmabadr and unassigned c-pius Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nesmabadr nesmabadr

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
3 participants
@ruanxin @nesmabadr @c-pius