Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set status.runtimeImage value after running function with a new image #945

Open
pPrecel opened this issue Apr 29, 2024 · 0 comments
Open
Labels
area/serverless Issues or PRs related to serverless

Comments

@pPrecel
Copy link
Contributor

pPrecel commented Apr 29, 2024

Description:

Right now we update the status.runtimeImage field almost at the beginning of the reconciliation which causes a few disadvantages because for example in this scenario:

  1. create a function with the nodejs18 runtime
  2. wait until the function is ready
  3. update runtime to nodejs20
  4. function fails on build because functions code does not support newer nodejs version

In such case, we would have in the status.runtimeImage field a newer version of an image that is not true because it failed on the build stage and right now on the cluster older version of this function is working.

@dbadura suggests that the status should reflect an actual version of the configuration, not the desired one

@pPrecel pPrecel added the area/serverless Issues or PRs related to serverless label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/serverless Issues or PRs related to serverless
Projects
None yet
Development

No branches or pull requests

1 participant