Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve serverless/operator-verify.yaml files #961

Closed
MichalKalke opened this issue May 7, 2024 · 0 comments
Closed

Improve serverless/operator-verify.yaml files #961

MichalKalke opened this issue May 7, 2024 · 0 comments
Assignees

Comments

@MichalKalke
Copy link
Contributor

Description:

At the beginning of prototyping the CI/CD system, we decided to locate all jobs related to the operator and serverless component in the serverless-verify.yaml and the operator-verify.yaml files. This solution brings a lot of disadvantages related to this kind of division:

  • push and pull_request jobs are in the same file and because of this we need to add ifs in every job to determine on which event every job should be run on
  • both files contain really similar jobs test kinds - for example, both files contain lint, integration tests, unit tests, and upgrade tests that are almost the same and have the same pre-config
  • the GitHub description under the PR or commit (after merging PR) show many skipped jobs

I think we have a few options to change this hierarchy.

  1. Split these files into pre/post files that would contain all event-related jobs
  2. Split these files into kind-related files like integration-tests.yaml, lint.yaml, and so on
  3. Option 1+2 - for example pre-integration-tests.yaml, post-integration-tests.yaml and so on
  4. Split these files into smaller files for every job to contain every job separately
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants