Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config for disabling istio #657

Open
a-thaler opened this issue Dec 20, 2023 · 1 comment
Open

Config for disabling istio #657

a-thaler opened this issue Dec 20, 2023 · 1 comment
Labels
area/manager Manager or module changes kind/feature Categorizes issue or PR as related to a new feature.

Comments

@a-thaler
Copy link
Collaborator

a-thaler commented Dec 20, 2023

Description

The manager currently detects at runtime if istio is available or not and then decides to manage some istio resources. The typical istio annotations are present independent of if istio is detected or not.

There can be situations where users want to use istio but run the telemetry module in non-istio mode. For that, a new module config setting is required to explicitly disable the istio mode. Also it must be assured that really any Istio feature is disabled.

Criterias

  • As a user I can explicitly disable the istio mode
  • Having the istio mode disabled, a running istio installation has no impact to the telemetry setup (no istio annotations are getting configured, no istio resources are generated)
  • Istio input of MetricPipelineis still supported, people only want to disable running telemetry with istio
  • Prometheus input of MetricPipeline does not support scraping from mtls endpoint

Reasons

Attachments

Release Notes


@a-thaler a-thaler added area/manager Manager or module changes kind/feature Categorizes issue or PR as related to a new feature. labels Dec 20, 2023
Copy link

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 19, 2024
@a-thaler a-thaler removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/manager Manager or module changes kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant