Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full test coverage for advanced status #919

Closed
4 tasks done
a-thaler opened this issue Mar 25, 2024 · 2 comments · Fixed by #1090
Closed
4 tasks done

Full test coverage for advanced status #919

a-thaler opened this issue Mar 25, 2024 · 2 comments · Fixed by #1090
Assignees
Labels
area/manager Manager or module changes kind/missing-test Categorizes issue or PR as related to missing automated tests for scenario.
Milestone

Comments

@a-thaler
Copy link
Collaborator

a-thaler commented Mar 25, 2024

Description

Before #425 can get finalized, the full feature must be covered by e2e tests. That mainly includes triggering every condition reason by a test setup.

Criterias

  • All reasons of the new condition are tested

Actions

  • Come up with a concept on how to test the feature. It is hard to test all situations. Maybe a contract test based on metrics is enough?
  • Implement tests for logs
  • Implement tests for traces
  • Implement tests for metrics

Reasons

Attachments

Release Notes


@a-thaler a-thaler added kind/missing-test Categorizes issue or PR as related to missing automated tests for scenario. area/manager Manager or module changes labels Mar 25, 2024
@skhalash skhalash self-assigned this Apr 30, 2024
@skhalash
Copy link
Collaborator

The following 2 test scenarios have been implemented for Log Pipelines:

  • Backend outage (by downscaling the mock backend to 0 replicas): the pipeline healthiness gradually degrades to AllTelemetryDataDropped
  • Backend backpressure (by deploying a Virtual Service with fault injection - 90% of requests get a 502 response): the pipeline healthiness gradually degrades to SomeTelemetryDataDropped

For both scenarios, there has been a separate job created. The jobs are stable and take <10 minutes to execute.

As the next step, we can implement the same scenarios for Metric and Trace Pipelines. What will not be covered is the gateway throttling scenario - I played around with it and didn't find a way to reproduce it even manually.

@skhalash
Copy link
Collaborator

In general, we want to test how OTel Collector and Fluent Bit instrumentation logic works. Contract based testing using mocks is not enough, we need the actual software running and negative scenarios simulated.

@a-thaler a-thaler added this to the 1.16.0 milestone May 10, 2024
@skhalash skhalash reopened this May 13, 2024
@skhalash skhalash removed their assignment May 16, 2024
@k15r k15r self-assigned this May 17, 2024
@a-thaler a-thaler removed this from the 1.16.0 milestone May 17, 2024
@k15r k15r linked a pull request May 21, 2024 that will close this issue
8 tasks
@a-thaler a-thaler added this to the 1.17.0 milestone Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/manager Manager or module changes kind/missing-test Categorizes issue or PR as related to missing automated tests for scenario.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants