Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use provided tag for image building instead of hardcoded tag format #10415

Open
triffer opened this issue Apr 15, 2024 · 0 comments
Open

Use provided tag for image building instead of hardcoded tag format #10415

triffer opened this issue Apr 15, 2024 · 0 comments
Labels
area/ci Issues or PRs related to CI related topics

Comments

@triffer
Copy link
Contributor

triffer commented Apr 15, 2024

Description
When building an image for a PR, that tag will always be in the format of PR-${PR_NUMBER}. You can provide a tag to the build, but it will be ignored. It is not obvious to the user that the tag is being ignored in this case.
We found out that the PR tag is hardcoded.

Reasons

Since we want to create multiple images with different features for a PR, we need to be able to specify a tag when we build an image for a PR.

Acceptance Criteria
Providing a tag to an image build for a PR will use the provided tag.

Attachments

@triffer triffer added the area/ci Issues or PRs related to CI related topics label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to CI related topics
Projects
None yet
Development

No branches or pull requests

1 participant