Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing the image builder default tag in postsubmit jobs #10446

Open
triffer opened this issue Apr 18, 2024 · 0 comments
Open

Allow changing the image builder default tag in postsubmit jobs #10446

triffer opened this issue Apr 18, 2024 · 0 comments
Labels
area/ci Issues or PRs related to CI related topics

Comments

@triffer
Copy link
Contributor

triffer commented Apr 18, 2024

Description
We need to build two different types of images with a different set of features for the istio-manager. For our postsubmit jobs on the main and release branches we defined an additional tag for each of those images (default image, experimental image).

The problem we are facing is that each of those builds also pushs an image tag with the format of v{{ .Date }}-{{ .ShortSHA }} defined in the kaniko-build-config.yaml.

Building our default image:
image

Building our image with experimental features:
image

Reasons
Make the tags created during image build reliable when building multiple tags for one commit.

The consequence is that the v{{ .Date }}-{{ .ShortSHA }} tag is unusable, because it's unreliable as whatever build finishes last will have that tag. We now have the risk that we publish tags that should not be used, but we cannot control this.

Acceptance Criteria
It would be good to have a possibility to override or extend the default tag in a job, so that
all image tags pushed during a postsubmit job can be controlled in the job configuration.

Attachments

@triffer triffer added the area/ci Issues or PRs related to CI related topics label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to CI related topics
Projects
None yet
Development

No branches or pull requests

1 participant