Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add multi-column invocations & ${ref} ${direction} @ .orderBy. #423

Merged
merged 6 commits into from
Jul 18, 2023
Merged

add multi-column invocations & ${ref} ${direction} @ .orderBy. #423

merged 6 commits into from
Jul 18, 2023

Conversation

igalklebanov
Copy link
Member

@igalklebanov igalklebanov commented Apr 13, 2023 •
edited

Hey 👋

This PR adds the ability to order by multiple columns in a single .orderBy invocation.

db
  .selectFrom('person')
  .select('first_name as fn')
  .selectAll()
  .orderBy(['fn', 'last_name desc'])

@igalklebanov igalklebanov added enhancement New feature or request api Related to library's API labels Apr 13, 2023
@igalklebanov igalklebanov added the blocked Blocked waiting for another feature label Apr 14, 2023
@vercel
Copy link

vercel bot commented Jul 16, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 7:58am

@igalklebanov igalklebanov removed the blocked Blocked waiting for another feature label Jul 16, 2023
@igalklebanov igalklebanov marked this pull request as ready for review July 17, 2023 19:11
koskimas
koskimas approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@koskimas koskimas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igalklebanov igalklebanov merged commit fe85562 into kysely-org:master Jul 18, 2023
5 checks passed
@igalklebanov igalklebanov deleted the order-by-enhanced branch July 18, 2023 08:39
Gaspero pushed a commit to Gaspero/kysely that referenced this pull request Oct 2, 2023
@igalklebanov @Gaspero
add multi-column invocations & ${ref} ${direction} @ .orderBy. (k…
61153b9 
…ysely-org#423)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koskimas koskimas koskimas approved these changes

Assignees
No one assigned
Labels
api Related to library's API enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@igalklebanov @koskimas