Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sql.raw): Allow parameters in raw sql #512

Merged
merged 3 commits into from
May 27, 2023
Merged

feat(sql.raw): Allow parameters in raw sql #512

merged 3 commits into from
May 27, 2023

Conversation

nicksrandall
Copy link
Contributor

Fixes #511

@vercel
Copy link

vercel bot commented May 22, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ❌ Failed (Inspect) May 27, 2023 2:34pm

@nicksrandall nicksrandall mentioned this pull request May 22, 2023
Closed
@igalklebanov igalklebanov added enhancement New feature or request api Related to library's API labels May 22, 2023
igalklebanov
igalklebanov reviewed May 23, 2023
View reviewed changes
Copy link
Member

@igalklebanov igalklebanov left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋

Thanks! 💪

I think that's a good idea.

Left some suggestions..

src/query-compiler/compiled-query.ts Outdated Show resolved Hide resolved
src/query-compiler/compiled-query.ts Outdated Show resolved Hide resolved
@nicksrandall
Copy link
Contributor Author

@igalklebanov I think this is ready. I applied your suggestions.

@koskimas koskimas merged commit dbaee55 into kysely-org:master May 27, 2023
3 of 4 checks passed
Gaspero pushed a commit to Gaspero/kysely that referenced this pull request Oct 2, 2023
@nicksrandall @igalklebanov @Gaspero
feat(sql.raw): Allow parameters in raw sql (kysely-org#512)
c19206d 
* feat(sql.raw): Allow parameters in raw sql

* use pre-compiled query

* Apply suggestions from code review

Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>

---------

Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalklebanov igalklebanov igalklebanov left review comments

Assignees
No one assigned
Labels
api Related to library's API enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raw query with parameters
3 participants
@nicksrandall @igalklebanov @koskimas