Expression builder v2

[koskimas]

This PR deprecates the cmpr and bxp functions and makes the ExpressionBuilder callable. eb can now be used to create all sorts of binary expressions. I didn't change the site examples yet, or otherwise they would be broken until we release this.

This PR also removes the deprecated orWhere, whereExits etc. methods. It might be a bit early to do that, but didn't find a way to make the expression builder callable while they existed.

The second commit introduces an alternative way to create and and or expressions. The old way is still there and won't be removed or deprecated. Some people prefer that one and it's (at least currently) much easier to create conditional or-expressions using the or([expr1, expr2]) function.

These changes now make simple or statements fluent and arguably more readable:

// The "old" way
db.selectFrom('person')
  .selectAll()
  .where(eb => eb.or([
    eb.cmpr('first_name', '=', 'Jennifer'),
    eb.cmpr('last_name', '=', 'Aniston')
  ])

VS

// The new way
db.selectFrom('person')
  .selectAll()
  .where(eb => 
    eb('first_name', '=', 'Jennifer').or('last_name', '=', 'Aniston')
  )

You can still destructure eb. eb contains a property eb that refers to itself:

db.selectFrom('person')
  .selectAll()
  .where(({ eb, or }) => or([
    eb('first_name', '=', 'Jennifer'),
    eb('last_name', '=', 'Aniston')
  ])

closes #494

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
kysely	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 7, 2023 0:40am

[igalklebanov]

Phenomenal stuff! 🙇

This is definitely a step in the right direction, removing the noise of cmpr and bxp, and adding the on-the-fly or/and chaining.

And all the deprecated code being deleted, music to my ears!! 😃

A small concern might be the addition of DB and TB to ExpressionWrapper's interface, and how it will affect consumers who make their own helpers. Is it still as flexible as before? I guess we'll find out and adjust if there are issues.

I'll do another pass tomorrow morning, it's late and I fear I missed some stuff.

[koskimas]

A small concern might be the addition of DB and TB to ExpressionWrapper's interface, and how it will affect consumers who make their own helpers. Is it still as flexible as before? I guess we'll find out and adjust if there are issues.

I don't think ExpressionWrapper is that useful in customer code. Expression and AliasedExpression are still simple.

[igalklebanov]

LET'S GO! 🚀