Add between method to expression builder

[koskimas]

Don't know if this is a good DX. Feel free to shoot this down.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
kysely	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 19, 2023 4:22pm

[igalklebanov]

I was praying and hoping for this day to come. 😄

My beloved between!!!! ✨

Looks good to me! 🚀

One thing to consider, PostgreSQL supports a between symmetric that should be a great QoL solution (no need to compare inputs before querying).

How would we tackle this? maybe..

eb.betweenSymmetric(expr, start, end)
// or
eb.between(expr, start, end).symmetric()

[koskimas]

Maybe eb.betweenSymmetric(expr, start, end) would be the lesser evil? Should I add it?

[igalklebanov]

Maybe eb.betweenSymmetric(expr, start, end) would be the lesser evil? Should I add it?

Yeah, seems like an easy win.

[koskimas]

I was praying and hoping for this day to come.

The only reason I was against between was that I didn't want to add whereBetween, orWhereBetween, onBetween etc. everywhere. In the expression builder, it's an easy and natural addition.

[frencojobs]

is this published yet?

[igalklebanov]

@frencojobs release pending.

[csulit]

I hope we get this. 😁