Support select queries without from clause #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
koskimas
force-pushed
the
select-without-from
branch
from
8d2cb55
to
29ce666
Compare
koskimas
force-pushed
the
select-without-from
branch
from
29ce666
to
bd2b1e9
Compare
|
@igalklebanov I changed the method name to |
igalklebanov
added
enhancement
koskimas
force-pushed
the
select-without-from
branch
from
bd2b1e9
to
5123a54
Compare
Gaspero
pushed a commit
to Gaspero/kysely
that referenced
this pull request
Oct 2, 2023
* support select queries without from clause * rename select --> selectNoFrom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been requested a lot. Let's hope knex peeps don't get too confused.
selectreturnsSelectQueryBuilderthat has join methods that are not supported without afromclause. The alternative was copy-pasting the wholeSelectQueryBuilderwithout the join methods. I think this is the lesser evil.